Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated AlphaDropout layer, seed=... was in wrong place #20326

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

ageron
Copy link
Contributor

@ageron ageron commented Oct 5, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.81%. Comparing base (5aa5f88) to head (c7f2fd0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20326   +/-   ##
=======================================
  Coverage   78.81%   78.81%           
=======================================
  Files         512      512           
  Lines       49063    49063           
  Branches     9035     9035           
=======================================
  Hits        38668    38668           
  Misses       8530     8530           
  Partials     1865     1865           
Flag Coverage Δ
keras 78.67% <ø> (ø)
keras-jax 62.26% <ø> (ø)
keras-numpy 57.40% <ø> (ø)
keras-tensorflow 63.55% <ø> (ø)
keras-torch 62.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Oct 5, 2024
@fchollet fchollet merged commit b083f2e into keras-team:master Oct 5, 2024
6 of 7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Oct 5, 2024
@ageron ageron deleted the fix-alphadropout branch October 5, 2024 03:42
@ageron
Copy link
Contributor Author

ageron commented Oct 5, 2024

This might be my fastest ever merged PR, thanks François! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants